Skip to content

fix: resolve 2 bugs in isscope - #249

Open
saurabhhhcodes wants to merge 1 commit into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-73230
Open

fix: resolve 2 bugs in isscope#249
saurabhhhcodes wants to merge 1 commit into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-73230

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Description

This PR fixes real bugs found in the codebase:

  • Added rejection handler to Promise.all: an unhandled rejection in any input promise previously crashed silently.
  • Replaced global isNaN with Number.isNaN: the global version coerces its argument, so isNaN('1') returns false while Number.isNaN is strict.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #248

A force refresh re-saved history with an empty analyses map, wiping
every stored analysis and forcing a full AI re-analysis of unchanged
issues on the next visit (tokens burned, queue slowed).

saveToHistory now merges the existing entry's analyses into the fresh
issue snapshot instead of overwriting them with an empty map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant