Skip to content

chore(deps): ignore unsafe-libyaml unmaintained advisory - #26640

Merged
pront merged 1 commit into
masterfrom
tess.neau/fix-unsafe-libyaml-advisory
Oct 13, 2026
Merged

pront merged 1 commit into
masterfrom
tess.neau/fix-unsafe-libyaml-advisory

Conversation

@tessneau

Copy link
Copy Markdown
Contributor

Summary

Cargo deny fails because serde_yaml and VRL's serde_yaml_ng pull in the now-flagged, unmaintained unsafe-libyaml crate. Add a scoped exception with no dependency or YAML parsing changes. There is no patched release, and the serde_yaml_ng backend migration is still pending upstream.

Vector needs its own exception because VRL's deny configuration does not carry over.

References

Vector configuration

N/A

How did you test this PR?

N/A

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Before pushing, follow our pre-push guidance.
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.

Temporarily ignore RUSTSEC-2024-0449 for serde_yaml and VRL’s serde_yaml_ng while the upstream backend migration is pending.

Generated with openai/gpt-6.1-sol.
@tessneau
tessneau requested a review from a team as a code owner October 12, 2026 13:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T13:26:50.473286Z 67c4131 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadoghq-integration datadoghq-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The exception targets the intended unsafe-libyaml advisory, and Cargo.lock confirms both YAML dependencies use that crate. The configuration parses successfully; cargo-deny itself was unavailable.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 67c4131

@tessneau tessneau added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 12, 2026
@pront
pront added this pull request to the merge queue Oct 13, 2026
Merged via the queue into master with commit 7dfaafe Oct 13, 2026
109 of 110 checks passed
@pront
pront deleted the tess.neau/fix-unsafe-libyaml-advisory branch October 13, 2026 13:56
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants