Repository navigation
fix(topology): preserve component failure details - #26549
Open
gwenaskell wants to merge 9 commits into
Open
gwenaskell wants to merge 9 commits into
gwenaskell wants to merge 9 commits into
Conversation
gwenaskell
force-pushed
the
yoenn.burban/socket-bind-error-context
branch
from
October 12, 2026 12:58
1aada76 to
c7982e2
Compare
gwenaskell
marked this pull request as ready for review
October 12, 2026 15:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The completed static review found the error adapters consistent with existing failure and shutdown behavior. Detailed causes are retained, while panic payloads remain outside shutdown reasons.
🤖 Bits Code Review · Commit a676693
tessneau
self-requested a review
October 13, 2026 16:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve runtime errors returned by sources and sinks in topology task failures. Existing components that return only
()still produce an opaque task error. Bind failures from TCP/UDP socket, syslog, and StatsD sources, and WebSocket server and Prometheus exporter sinks, now include their causes. Console encoding and write errors, Kafka and MQTT subscription errors, journald checkpoint open errors, and AMQP consumer errors also retain their causes.Log string panic payloads in a structured
panicfield when a source, transform, or sink task panics. Concurrent transform child panics reach the same handler. The panic payload does not enter the log message or shutdown reason.Example runtime log
With a TCP socket source named
inwhose port is already held by another listener, the topology emitted this line in the regression test on macOS:The OS error number and text vary by platform.
A remap transform named
grok, fed the messagefoo=NaN, also demonstrates the structured panic field:The topology emitted this line:
This reproduction uses
parse_groks!, which runs the Datadog Grokkeyvaluefilter.parse_grok!uses standard Grok, where%{LOGLEVEL:keyvalue}names a capture.References
None.
Vector configuration
Regression tests build topologies with TCP/UDP socket, syslog, and StatsD sources, and WebSocket server and Prometheus exporter sinks, while another listener holds the configured address. A console sink unit test closes its output pipe to check that the sink retains the original I/O error.
How did you test this PR?
cargo test --no-default-features --features sources-socket,sinks-socket,sinks-websocket_server,test-utils --lib topology::test::crash:: -- --nocapture --test-threads=1(7 passed)cargo test -p vector --no-default-features --features sources-socket,sources-syslog,sources-statsd,sources-kafka,sources-mqtt,sources-journald,sources-amqp,sinks-socket,sinks-websocket_server,sinks-prometheus,test-utils --lib topology::test::crash:: -- --test-threads=1(10 passed)cargo test --no-default-features --features sources-socket,sinks-socket,sinks-websocket_server,test-utils --lib topology::test::panic:: -- --nocapture(2 passed)cargo test --no-default-features --features sources-socket,sources-syslog,sinks-socket,sinks-websocket_server,test-utils --lib test_udp_syslog_bind_error_is_reported -- --nocapture(1 passed)cargo test -p vector --no-default-features --features sinks-console write_error_retains_cause -- --nocapture(1 passed)cargo test -p vector --no-default-features --features sinks-console sinks::console::sink::test::component_spec_compliance(1 passed)FEATURES=sources-socket,sinks-socket,sinks-websocket_server,test-utils make check-clippyFEATURES=sinks-console make check-clippyFEATURES=sources-socket,sources-syslog,sources-statsd,sources-kafka,sources-mqtt,sources-journald,sources-amqp,sinks-socket,sinks-websocket_server,sinks-prometheus,test-utils make check-clippymake check-clippy(all features)sinks-blackhole,sinks-humio,sinks-sematext,aws-core,test-utils(3 passed)sources-stdin,transforms-remap,sinks-consoleand ran thefoo=NaNremap configuration above; verified the topology log includes the panic fieldmake check-fmtmake check-changelog-fragmentsmake check-markdownDoes this PR include user facing changes?