fix(ci): start the Helm release after post-release housekeeping - #26542
Draft
thomasqueirozb wants to merge 1 commit into
Draft
thomasqueirozb wants to merge 1 commit into
thomasqueirozb wants to merge 1 commit into
Conversation
1 of 2 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start the Helm chart release only after post-release housekeeping has pushed to
master.The Helm release ends with the Kubernetes manifests refresh, which pushes to
master. Today it starts in parallel with housekeeping. Housekeeping recordsmasterwhen it starts and refuses to push ifmastermoved while it was generating, so a manifests push that lands during that window fails housekeeping. The automatic unfreeze then sees the failed Release Suite and keeps the freeze active, which needs a housekeeping re-run and a manual unfreeze dispatch.With
prepare-helm-releasedepending onhousekeeping, the manifests refresh always starts from amasterthat already contains the housekeeping commit. If housekeeping fails, "Re-run failed jobs" on Release Suite also re-runs the Helm dispatch, so the chain, including the automatic unfreeze, completes without manual steps. The Helm release starts about 10 to 15 minutes later.References
Related: #26538
Vector configuration
NA
How did you test this PR?
masterat 20:59:26, the manifests refresh pushed at 21:03:40, and housekeeping failed with "master moved since housekeeping was generated". The sandbox Helm CI skips kind andct install, so the Helm chain finished much faster than in production.actionlint .github/workflows/release.ymlpassed.Does this PR include user facing changes?
no-changeloglabel to this PR.