fix(cli[colors]): Let explicit color override NO_COLOR

why: The test environment sets NO_COLOR, but explicit color requests are command choices and should still force ANSI output for tests and --color=always-style paths.

what:

- Make ColorMode.ALWAYS take precedence over NO_COLOR

- Keep ColorMode.AUTO respecting NO_COLOR

- Add regression coverage for both precedence paths

Author: tony

src/vcspull/cli/_colors.py

@@ -43,20 +43,36 @@ def __init__(self, mode: ColorMode = ColorMode.AUTO) -> None:
     def _should_enable_color(self) -> bool:
         """Determine if color should be enabled.
 
+        Explicit color modes are command choices and take precedence over
+        environment defaults:
+
+        >>> import os
+        >>> from vcspull.cli._colors import ColorMode, Colors
+        >>> previous = os.environ.get("NO_COLOR")
+        >>> os.environ["NO_COLOR"] = "1"
+        >>> Colors(ColorMode.ALWAYS)._should_enable_color()
+        True
+        >>> Colors(ColorMode.NEVER)._should_enable_color()
+        False
+        >>> if previous is None:
+        ...     _ = os.environ.pop("NO_COLOR", None)
+        ... else:
+        ...     os.environ["NO_COLOR"] = previous
+
         Returns
         -------
         bool
             True if colors should be enabled
         """
-        # Respect NO_COLOR environment variable
-        if os.environ.get("NO_COLOR"):
-            return False
-
         if self.mode == ColorMode.NEVER:
             return False
         if self.mode == ColorMode.ALWAYS:
             return True
 
+        # Respect NO_COLOR environment variable for AUTO mode.
+        if os.environ.get("NO_COLOR"):
+            return False
+
         # AUTO mode: check if stdout is a TTY
         return sys.stdout.isatty()
 

tests/cli/test_colors.py

@@ -0,0 +1,30 @@
+"""Tests for vcspull CLI color mode resolution."""
+
+from __future__ import annotations
+
+import typing as t
+
+from vcspull.cli._colors import ColorMode, Colors
+
+if t.TYPE_CHECKING:
+    from _pytest.monkeypatch import MonkeyPatch
+
+
+def test_color_mode_always_overrides_no_color(monkeypatch: MonkeyPatch) -> None:
+    """An explicit color request wins over the NO_COLOR environment default."""
+    monkeypatch.setenv("NO_COLOR", "1")
+
+    colors = Colors(ColorMode.ALWAYS)
+
+    assert colors._enabled
+    assert colors.info("repo") != "repo"
+
+
+def test_color_mode_auto_respects_no_color(monkeypatch: MonkeyPatch) -> None:
+    """Automatic color mode still respects NO_COLOR."""
+    monkeypatch.setenv("NO_COLOR", "1")
+
+    colors = Colors(ColorMode.AUTO)
+
+    assert not colors._enabled
+    assert colors.info("repo") == "repo"