docs(adr): record the single local-batch intake in ADR-SYNC-001 - #261
Merged
Conversation
Amend the offline-first sync ADR with the S7 refinement: all locally-produced batches enter the coordinator through one submitLocalBatch intake (one intake, two producers, one seq authority), a direct oplog write desyncs a synced board, and a headless / off-scene producer must pass scene:false so its off-layer ops never join the rebase set. Adds the subtree deep-cascade bypass as the fixed example, plus a Verify grep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
S7c — the docs half of the sync-spine work. Amends ADR-SYNC-001 to record the "single local-batch intake" refinement introduced by #259 (S7a) and #260 (S7b). Docs only, no code.
Changes to the ADR
submitLocalBatchintake, never a direct oplog write. One intake, two producers, one seq authority — the store scene (attachSync.sendBatch) and any headless / off-scene producer (getBoardSyncRef()) both funnel here. A headless producer MUST passscene: false, so its off-layer ops never join the rebase set (elseapplyRemote's undo/replay injects them into the current scene), and MUST record to the oplog before submitting.persistence.recordwithout entering the intake lands in the oplog but triggers no pump, so it ships only opportunistically and isn'tserverSeq-stamped promptly. The deep-layer cascade delete (graph/subtree.ts) was the last such bypass, now fixed in fix(sync): pump deep-layer cascade deletes through the sync intake #260.graph/subtree.ts; Verify adds agrepforsubmitLocalBatch(confirmed to resolve to exactly the two producers).Notes