fix(drawify): use handwriting font for drawn nodes and links - #249
Merged
Conversation
Drawify explicitly overrode the font to INFORMAL on both notes and links; switch back to HANDWRITING (the Style default) so drawn output matches the board's default hand-drawn look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drawify's drawn nodes and links now use the handwriting font instead of informal.
Why
convert_drawify_output_to_notes_linksexplicitly setfont_family = FontFamily.INFORMALon both notes (drawify.py:85) and links (:112), overriding theStyledefault ofFontFamily.HANDWRITING. The frontend keeps drawify's style verbatim (storeMindMap({ preserveStyle: true })), so that override reached the canvas — drawn output rendered in the informal font rather than the board's default hand-drawn look.Change
Two lines:
FontFamily.INFORMAL→FontFamily.HANDWRITINGon the note and the link. (Left as explicit assignments, matching the surrounding style-setting lines, rather than dropping to the implicit default.)Testing
No test pins drawify's font (the only
font_familyassertions in the suite are for an unrelatedserifop-apply case).ruffwasn't available in my environment, but the change is a swap between two existing, already-importedFontFamilyenum members — no import, formatting, or line-length impact.