Some fixes for fastgltf - #93
Open
spnda wants to merge 2 commits into
Open
Conversation
spnda
force-pushed
the
fastgltf_fixes
branch
from
December 28, 2023 18:18
ad61d67 to
7530047
Compare
spnda
marked this pull request as ready for review
December 28, 2023 18:18
spnda
force-pushed
the
fastgltf_fixes
branch
from
December 28, 2023 19:34
7530047 to
9de716f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes compilation on macOS (and perhaps Linux, too?) but I am aware it doesn't run on macOS because MVK doesn't support Vulkan 1.3.
I also fixed some things about the usage of fastgltf, but I'm still looking for others so I'm marking this as WIP for now.