Dummy Identifier value to skip screen - #25
Open
Timshel wants to merge 1 commit into
Open
Conversation
Author
|
@stefan0xC Hey, Recently started building the Firefox extension because I got tired of putting a dummy email and then pressing enter, then backtracking since I want SSO and not password login. Wanted to propose it to the SSO user of Vaultwarden too, but without this patch the extension drop you in the identifier screen. Might be able to set the identifier, but I believe this patch is relatively simple and make sense since it's not really needed for the user to have to set and identifier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent change around
/organizations/domain/sso/verifiedit now always return the hardcoded value.I think it makes sense to set it in the client, this allows to use a cleaner
/#/ssofor those who prefer to skip the email prompt (logout still redirect to login form with email sadly). And if it needs to change again lessen the risks of someone using an outdated value.If called with the hardcoded identifier
auto-enroll-statuscan return a different Organization.I believe it does not cause issues but at the same time the value is later used in