Skip to content

Move leaderboards into speedrun modes - #30

Merged
vasiltop merged 2 commits into
vasiltop:mainfrom
matteopolak:matteopolak-move-speedrun-leaderboards
Jul 18, 2026
Merged

Move leaderboards into speedrun modes#30
vasiltop merged 2 commits into
vasiltop:mainfrom
matteopolak:matteopolak-move-speedrun-leaderboards

Conversation

@matteopolak

@matteopolak matteopolak commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a dedicated Leaderboard tab inside the Speedrun mode switcher
  • preserve the old side-by-side Target Practice and Movement Only ranking layout
  • remove the redundant top-level Leaderboard tab and keep map layout ownership centralized in ModeContainer
  • preserve existing leaderboard refresh behavior and add scene-structure regression coverage

Test plan

  • ./scripts/test-godot.sh
  • pre-push server quality, server tests/build, website build, Godot suite, and E2E smoke test

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9dbb5603-34d4-46e7-91ce-d0a49488bf15
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vasiltop

Copy link
Copy Markdown
Owner

It looks really bad, would it be possible to move it into its own tab? like in the ModeSwitcher node? this might require a bit of refactor to do but It would look a lot better closer to the old style

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9dbb5603-34d4-46e7-91ce-d0a49488bf15
@matteopolak

Copy link
Copy Markdown
Contributor Author

It looks really bad, would it be possible to move it into its own tab? like in the ModeSwitcher node?

Reworked in bde200c: Speedrun now has a dedicated nested Leaderboard tab using the old side-by-side Target Practice and Movement Only layout. The temporary duplicated map-layout scene trees were also removed, with ModeContainer restored as the single owner of map layout.

@vasiltop
vasiltop merged commit 3223cce into vasiltop:main Jul 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants