Fix frontend auth success routing - #7
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Vasanth Panuganti <vpanuga2@asu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Successful login/signup crashed in the frontend because the success handler expected
data.session.access_token, while the backend returnsdata.tokens.accessToken. Even if that crash was bypassed, auth redirected to/dashboardwhile the dashboard page lived in a route group that resolved to/, creating a broken post-auth path and a root route conflict.Root cause
The frontend auth response type and hook were out of sync with the backend auth contract, and the dashboard route files were placed under
app/(dashboard)instead of the/dashboardURL segment used by redirects and navigation.Fix
useAuthsuccess handlers to readtokens.accessToken/tokens.refreshToken.app/dashboard/...so/dashboardand/dashboard/recipesare real routes.Validation
pnpm --filter @snacktrack/frontend test -- src/lib/hooks/use-auth.test.tsx src/app/dashboard/layout.test.tsx-> 5 tests passed.pnpm --filter @snacktrack/shared-types build && pnpm --filter @snacktrack/frontend build-> production build succeeded and listed/dashboardand/dashboard/recipesroutes./dashboard->/dashboard/recipes->/dashboardrouting.