Fix signup application user creation - #6
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Vasanth Panuganti <vpanuga2@asu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Successful
/auth/signupcalls created a Supabase auth identity but never inserted the correspondingusersrow. Newly signed-up users could receive tokens, but protected app APIs such as/users/me, preferences, allergens, meal logs, and account deletion would fail withUSER_NOT_FOUNDor FK errors.Root cause
AuthService.signUpreturned success immediately after Supabase signup and only started ML warmup. The backend uses Supabase user IDs as primary keys in the local Prismauserstable, but signup never persisted that local row.Fix
prisma.userrow with the Supabase user ID, email, and display name before returning signup success.SIGNUP_PROFILE_FAILEDinstead of leaving an orphaned unusable auth identity.Validation
pnpm --filter @snacktrack/backend test -- tests/auth.test.tspasses (2 tests).pnpm --filter @snacktrack/backend build.tests/health.test.tsfailure is due to the health route checking ML health while the legacy health test only mocks DB/Redis, unrelated to this signup change.