feat: honor pretscheck as primary pre-script alias for tsc#241
Merged
Conversation
Now that the typecheck task is canonically named tscheck (#240), a package's pretscheck script runs before the type check, taking precedence over the legacy pretsc/pretypecheck aliases (still honored as fallbacks). Adds integration coverage for the pre-script feature, which previously had none. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5a5faa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Integration tests spawn the real rr bin and run actual toolchains (tsc, biome, oxlint), which exceeds vitest's 5s default on contended CI runners and fails the job by timeout. Set testTimeout/hookTimeout to 30s for the integration project so the budget covers all of them in one place, and drop the one-off inline 15s override in only.test.ts (the oxc tsgolint dispatch) so it inherits that single budget too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rqbazan
force-pushed
the
feat/tsc-pretscheck-prescript
branch
from
June 15, 2026 23:38
ee375fa to
1b355e6
Compare
Contributor
Preview releaseLatest commit: Some packages have been released:
Note Use the PR number as tag to install any package. For instance: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
pretscheckto the front of therr tscpre-script precedence chain:Why
#240 standardized the typecheck task as
tscheck. The npmpre<script>convention implies the matching pre-hook should bepretscheck— so a package'spretschecknow runs (captured, inside the task) before the type check. The legacypretsc/pretypecheckaliases remain as fallbacks, so nothing breaks for existing setups.Tests
The pre-script feature previously had no coverage. This PR adds two integration tests in
test/integration/tsc.test.ts:pretscheckruns before tsc and fails the task when it fails.pretschecktakes precedence over the legacypretsc/pretypecheckaliases (the legacy scripts never fire).pnpm rr checkand the full@rrlab/clitest suite are green; apatchchangeset is included.🤖 Generated with Claude Code