Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lefthook/turborepo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pre-commit:
stage_fixed: true

- name: tscheck
run: pnpm turbo run test:types --filter='...[HEAD]'
run: pnpm turbo run tscheck --filter='...[HEAD]'
glob:
- "*.{ts,tsx}"
- "tsconfig.json"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scripts": {
"build": "turbo build",
"test": "turbo test",
"test:types": "turbo test:types",
"tscheck": "turbo tscheck",
"test:unit": "turbo test:unit",
"test:integration": "turbo test:integration"
},
Expand Down
2 changes: 1 addition & 1 deletion run-run/CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Orientation for working on the `@rrlab/*` packages. Prerequisite reading: the re

This means:

- **Do not wrap `rr` in `package.json` scripts.** Aliases like `"lint": "rr lint"`, `"format": "rr format --fix"`, `"test:types": "rr tsc"`, `"check": "rr check"` re-introduce the very indirection rr was created to remove (`pnpm lint` → `rr lint` → `biome check` is three layers for what should be one). The user types `rr lint`, not `pnpm lint`.
- **Do not wrap `rr` in `package.json` scripts.** Aliases like `"lint": "rr lint"`, `"format": "rr format --fix"`, `"tscheck": "rr tsc"`, `"check": "rr check"` re-introduce the very indirection rr was created to remove (`pnpm lint` → `rr lint` → `biome check` is three layers for what should be one). The user types `rr lint`, not `pnpm lint`.
- **The expected setup**: `node_modules/.bin` on `PATH` — typically via mise (`[env] _.path = ["{{config_root}}/node_modules/.bin"]`) — so `rr` is directly invokable from the project root without a package-manager hop. Templates ship a `mise.toml` that wires this for new projects.
- **`package.json scripts` may still exist** — but only for things `rr` does NOT cover (`vitest run`, `tsx watch`, `node dist/...`, `vite dev`, `turbo run dev`, `changeset publish`). These are not single-command aliases; they're either different tools or multi-step compositions.
- **Lifecycle / orchestration hooks MAY call `rr` directly.** lefthook git hooks, `prepublishOnly`, GitHub Actions workflows — those are triggered by other systems, not typed by the developer, so they don't fight the "one entry point" goal. A `pre-commit: rr jsc --fix-staged` lefthook job is exactly right.
Expand Down
2 changes: 1 addition & 1 deletion run-run/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"test:unit": "vitest run --project unit",
"test:integration": "vitest run --project integration",
"prepublishOnly": "pnpm build",
"test:types": "rr tsc"
"tscheck": "rr tsc"
},
"dependencies": {
"@clack/prompts": "0.11.0",
Expand Down
2 changes: 1 addition & 1 deletion shared/clibuddy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"build": "tsdown",
"prepublishOnly": "pnpm build",
"test": "vitest run",
"test:types": "rr tsc"
"tscheck": "rr tsc"
},
"dependencies": {
"@pnpm/fs.find-packages": "1000.0.24",
Expand Down
2 changes: 1 addition & 1 deletion shared/loggy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"scripts": {
"build": "tsdown",
"prepublishOnly": "pnpm build",
"test:types": "rr tsc"
"tscheck": "rr tsc"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"test": {
"dependsOn": ["build"]
},
"test:types": {},
"tscheck": {},
"test:unit": {},
"test:integration": {
"dependsOn": ["build"]
Expand Down
2 changes: 1 addition & 1 deletion vland/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"test": "vitest run",
"test:unit": "vitest run --project unit",
"test:integration": "vitest run --project integration",
"test:types": "rr tsc"
"tscheck": "rr tsc"
},
"dependencies": {
"@clack/prompts": "0.11.0",
Expand Down
2 changes: 1 addition & 1 deletion vland/cli/test/integration/init-templates.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe("vland init (template scaffolding)", () => {
const scriptNames = Object.keys(pkg.scripts ?? {});
expect(scriptNames).not.toContain("lint");
expect(scriptNames).not.toContain("lint:fix");
expect(scriptNames).not.toContain("test:types");
expect(scriptNames).not.toContain("tscheck");
expect(scriptNames).not.toContain("check");
expect(scriptNames).not.toContain("build");
});
Expand Down
Loading