chore: restore lefthook/turborepo.yml and extend it from root#239
Merged
Conversation
Restore the shared lefthook turborepo config that was inlined into the root lefthook.yml during the microkernel refactor (#220). The root lefthook.yml now extends lefthook/turborepo.yml instead of duplicating its jobs, keeping a single source of truth for the hook definitions. Verified with `lefthook dump`: the merged config is identical to the previous inline definition. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The blacksmith-4vcpu-ubuntu-2404 runner is no longer available. Switch the test job to ubuntu-latest, matching the release and preview jobs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores the
lefthook/folder at the repo root withturborepo.yml, and rewires the rootlefthook.ymltoextendsit instead of inlining the job definitions.Why
The shared lefthook turborepo config (originally
packages/config/src/lefthook/turborepo.yml, added in #161, fixed in #180) was dismantled along with thepackages/configpackage during the microkernel refactor (#220). Its content was copy-pasted directly into the rootlefthook.yml.This restores it as a standalone file and makes the root config a thin pointer, so the hook definitions have a single source of truth again.
Details
lefthook/turborepo.yml— restored byte-for-byte from the pre-refactor version (commit14c8f7a).lefthook.yml— reduced to:jscheck,tscheck,test), so lefthook merges by name with no duplication.Verification
lefthook dumpconfirms the merged effective config is identical to the previous inline definition (samepre-commitandpre-pushhooks).pnpm rr checkpasses (biome + oxlint type-aware across all 8 packages).pre-commithook ran cleanly on this very commit.🤖 Generated with Claude Code