Repository navigation
fix: resolve string video model IDs via AI_SDK_DEFAULT_PROVIDER - #234
Merged
Merged
Conversation
`<Video model="seedance_2_5" />` passed a string to generateVideo(), which called model.doGenerate() directly — strings have no doGenerate, causing "model.doGenerate is not a function" on every clip. generateImage() from the Vercel AI SDK already resolves string IDs via globalThis.AI_SDK_DEFAULT_PROVIDER (set by the render service before render()). This adds the same resolution to generateVideo(), plus a toVideoModelV3() shell for preview mode (matching toImageModelV3()). VideoProps.model, TalkingHeadProps.model/lipsyncModel, and DefaultModels.video now accept VideoModel (string | VideoModelV3). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 Walkthroughwalkthroughvideo generation now accepts string model ids or changesvideo model support
estimated code review effort: 3 (moderate) | ~20 minutes sequence diagram(s)sequenceDiagram
participant caller
participant generateVideo
participant defaultProvider
participant previewRenderer
caller->>generateVideo: provide string model id
generateVideo->>defaultProvider: resolve video model
defaultProvider-->>generateVideo: return VideoModelV3
generateVideo->>previewRenderer: render with resolved model
poem
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SecurityQQ
added a commit
that referenced
this pull request
Aug 24, 2026
Brings the computation-graph IR, render lifecycle split, and derived audio nodes (vid.audio with transcribe/speechRange/silence detection) to main. Resolved conflicts in audio.ts (combined resolveVideoMixVolume + renderAudio), clip.ts (import line), render.ts (took feature branch refactored structure, integrated resolveVideoMixVolume into renderOverlays), and context-builder.ts (added toVideoModelV3 for string model ID support from PR #234). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<Video model="seedance_2_5" />passed a string togenerateVideo(), which calledmodel.doGenerate()directly — strings have nodoGenerate, causing"model.doGenerate is not a function"on every clip.generateImage()from the Vercel AI SDK already resolves string IDs viaglobalThis.AI_SDK_DEFAULT_PROVIDER(set by the render service beforerender()). This adds the same resolution togenerateVideo().toVideoModelV3()shell for preview mode (matching existingtoImageModelV3()).VideoProps.model,TalkingHeadProps.model/lipsyncModel, andDefaultModels.videonow acceptVideoModel(string | VideoModelV3).Test plan
tsc --noEmitpasses (0 new errors)bun test src/react/renderers/— all pass<Video model="seedance_2_5" />succeedsGenerated with Devin