Skip to content

Modernise - #81

Open
0xTim wants to merge 5 commits into
mainfrom
modernise
Open

Modernise#81
0xTim wants to merge 5 commits into
mainfrom
modernise

Conversation

@0xTim

@0xTim 0xTim commented Aug 12, 2026

Copy link
Copy Markdown
Member

Add modernisation changes as per Modernisation

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.30409% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.94%. Comparing base (e9eb03f) to head (8405643).

Files with missing lines Patch % Lines
.../Authentication/Passwords/Bcrypt/VaporBcrypt.swift 87.20% 11 Missing ⚠️
.../Authentication/Passwords/Bcrypt/BcryptError.swift 68.75% 5 Missing ⚠️
Sources/Authentication/OTP/OTP.swift 93.10% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files           8        8           
  Lines         199      199           
=======================================
  Hits          177      177           
  Misses         22       22           
Files with missing lines Coverage Δ
Sources/Authentication/Helpers/Data+Array.swift 100.00% <ø> (ø)
...Authentication/Passwords/Bcrypt/BcryptHasher.swift 100.00% <100.00%> (ø)
...rces/Authentication/Passwords/PasswordHasher.swift 100.00% <ø> (ø)
...ces/Authentication/Passwords/PlaintextHasher.swift 100.00% <ø> (ø)
Sources/Authentication/OTP/OTP.swift 93.10% <93.10%> (ø)
.../Authentication/Passwords/Bcrypt/BcryptError.swift 68.75% <68.75%> (ø)
.../Authentication/Passwords/Bcrypt/VaporBcrypt.swift 86.20% <87.20%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .swift-format
"spaces": 4
},
"indentConditionalCompilationBlocks": false,
"indentConditionalCompilationBlocks": true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMVHO this adds a lot of unnecessary indentation, like in those test files

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree for the most part, we just need to decide what to standardise on for Vapor. This was copied over from routing-kit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants