Support APNSwift 7.0.1 and modernise the package - #62
Open
kylebrowning wants to merge 5 commits into
Open
Conversation
The dependency was pinned to `from: "6.1.0"`, which SPM resolves as >=6.1.0 <7.0.0, so VaporAPNS could not pick up APNSwift 7. No source changes are needed: the package builds and the full test suite passes against 7.0.0 unchanged. Also refreshes two doc comments that referenced APIs deprecated in APNSwift 7: - `P256.Signing.PrivateKey.loadFrom(string:)` is deprecated in favor of `init(pemRepresentation:)` - `APNSEnvironment.sandbox` is deprecated in favor of `.development`
0xTim
requested changes
Aug 12, 2026
0xTim
left a comment
0xTim
left a comment
Member
There was a problem hiding this comment.
We should update CI for the latest changes and bump the swift version to 6.1. There are. also a number of changes we want to make, I don't know if we want to do a major version release now or wait
Member
Author
|
IM happy to do them now. What did you have in mind? |
Member
|
See Modernisation for the list! |
Raise the tools version to 6.2 and adopt the standard Vapor swift settings on both targets. InternalImportsByDefault and MemberImportVisibility account for the import changes; APNSCore becomes an explicit dependency because APNSEnvironment's members are declared there and APNS doesn't re-export it. Declare tvOS 16 and watchOS 9, both already supported by APNSwift and Vapor. De-duplicate the test helpers into TestUtilities.swift, and await application shutdown rather than detaching it into a Task that raced the teardown it was meant to perform. Enable linting, musl and iOS in CI, add dependency submission, and add the shared .swift-format config.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage ? 92.22%
=======================================
Files ? 4
Lines ? 90
Branches ? 0
=======================================
Hits ? 83
Misses ? 7
Partials ? 0
🚀 New features to boost your workflow:
|
0xTim
requested changes
Aug 14, 2026
JSONEncoder and JSONDecoder are Sendable in corelibs-foundation as of Swift 6.2, so the @preconcurrency import is unnecessary — and it fails StrictMemorySafety, which broke the Linux and musl builds.
kylebrowning
force-pushed
the
apnswift-7
branch
from
August 14, 2026 18:25
7bc9599 to
bdb25fd
Compare
7.0.1 links FoundationEssentials rather than full Foundation, which vapor/apns needs before the Foundation linking check can be enabled.
kylebrowning
changed the title
fpseverino
reviewed
Aug 15, 2026
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VaporAPNS was capped at APNSwift 6.x, and the package predated the current Vapor tooling baseline.
Modifications
TestUtilities.swiftand await application shutdown rather than racing it in a detachedTask..swift-formatconfig.Result
Builds and tests pass on macOS, Linux (6.2 and 6.3), musl and iOS.
api-breakagereports fournonisolatedchanges onApplication.APNSfromNonisolatedNonsendingByDefault. Intended, and why this warrants a major release.