Repository navigation
fix: ship the update workflow in the package - #64
Merged
Merged
Conversation
modules.autoupdate with `github.workflows.source: local` gives the repository its own copy of repokeeper-update.yml, read from the installed package. The file was missing from the package's `files`, so that copy could not be read: it worked from a checkout of this repository and would have failed from npm. A test now checks that every reusable workflow a repository can be given a copy of is covered by `files`.
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
modules.autoupdate: truewithgithub.workflows.source: localgives the repository its own copy ofrepokeeper-update.yml. The copy is read from the installed package, and the file was not in the package'sfiles. It worked from a checkout of this repository, which is where #62 was tried, and fails from npm:Repositories that call the workflows from
vannt-dev/repokeeper(the default) are not affected: they never read the file from the package.The fix
package.json:.github/workflows/repokeeper-update.ymladded tofiles.test/package-files.test.ts: every reusable workflowlistWorkflows()names must be covered byfiles. It failed with[ 'repokeeper-update.yml' ]before the change.Tested
typecheck,lint, 435 tests,build,npm run standard.npm packwithpackage.jsonas onmainand as on this branch, each tarball installed in an empty project and run in a new repository whose.repokeeper.ymlhasmodules.autoupdate: trueandgithub.workflows.source: local. Before: theENOENTabove, nothing written. After:initapplies the standard and.github/workflows/holdsrepokeeper-autoupdate.ymland the copyrepokeeper-update.yml.No changelog entry is needed for users: the feature it repairs has not been released.