Repository navigation
fix(standard): move lefthook to 2.2.1 and Renovate to 44.149.2 - #60
Merged
Merged
Conversation
Nothing keeps the tool versions the standard writes up to date: Dependabot watches package.json and the workflows' actions, not TOOL_VERSIONS. Two had fallen behind. Generated output changes for every repository, so the standard moves to 1.4.4. Moving the lefthook range is the first time update changes package.json and nothing else, which leaves the lockfile behind and makes npm ci stop. update now says to install again and commit the lockfile. This repository is updated to 1.4.4 with its lockfile. The tests that named the versions as literals read them from TOOL_VERSIONS, the playground follows the standard, and biome.json names the schema of the biome that is installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing keeps the tool versions the standard writes into a repository up to date: Dependabot watches
package.jsonand theuses:lines of the workflows, notTOOL_VERSIONS. Checked against the registries, two had fallen behind:^range in a Node.js project'spackage.json;npx --yes lefthook@… installinCONTRIBUTING.mdand in the hint afterinitrenovatejob on GitLabEverything else is current: commitlint, semantic-release and its plugins, shfmt, PSScriptAnalyzer.
conventional-changelog-conventionalcommitsstays at 9.3.1 on purpose (the comment beside it says why).Generated output changes for every repository, so the standard moves to 1.4.4. A repository only sees it when it runs
repokeeper updatewith the new version; its drift check keeps running the version that wrote its standard.A hint that was missing
Moving the lefthook range is the first time
updatechangespackage.jsonand nothing else, and it leaves the lockfile behind:npm cithen stops with "package.json and package-lock.json are not in sync".updatenow says so:This repository is the first to need it: it is updated to 1.4.4 here, with its lockfile.
Tested
With this build packed and installed as the published package would be:
init, thennpx --yes lefthook@2.2.1 install: the three hooks are installed; a commit with a bad subject is refused by commitlint, a good one goes through.updatewrites the range and prints the hint; afternpm installa bad subject is refused, a good one accepted, and the pre-push hook runs the tests.update,npm cifailed with the message above while the lockfile still named 2.1.17; afternpm install, it passes. The lockfile was regenerated with the current npm so that only the lefthook entries move..repokeeper.ymland the lock; projects without Node.js also byCONTRIBUTING.md; Node.js projects bypackage.json; GitLab projects also by.gitlab-ci.yml. Nothing else.npm run lint,npm run typecheck,npm test(430 tests),repokeeper checkon this repository.Not tested
Also
TOOL_VERSIONSnow, so the next move is one file.biome.jsonnamed the schema of 2.5.14 after the move to 2.5.15 this morning; biome said so on every run.Seen on the way, not changed
npm install-scripts approve). "Install dependencies; this installs the git hooks" relies on lefthook's install script, so it will need another look when npm 12 is what people have.npm install @commitlint/cli@…incommitlint.ymland the shfmt and PSScriptAnalyzer versions instack-script.ymlare not watched by anything either. They are current today.🤖 Generated with Claude Code