Keep Unicode titles from lossy download output#98
Merged
vanloctech merged 1 commit intoJul 4, 2026
Conversation
Windows process output can drop Vietnamese characters in yt-dlp progress lines, so completed single downloads now prefer metadata or the UTF-8 final filepath when choosing the display title. Playlist items keep the current item title so collection/history rows do not regress. Constraint: yt-dlp stdout/stderr can be decoded differently from the final filesystem path on Windows. Rejected: Always prefer filepath titles | playlist outputs can use representative filenames that are less accurate than the current playlist item title. Confidence: high Scope-risk: narrow Directive: Do not let lossy progress output override a known-good metadata or final filepath title for single downloads. Tested: bun run build:sdk Tested: cargo test display_title --lib Tested: cargo check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
bun run build:sdkcargo test display_title --libcargo check