support dynamic defaults via registered callback functions#10
Open
eldridge wants to merge 1 commit into
Open
Conversation
eldridge
force-pushed
the
dynamic-defaults
branch
from
August 28, 2019 01:09
af1a7ae to
eebca28
Compare
Contributor
|
I like it - could we extend the scope larger than just default values? Could we use a similar syntax to specify a set of properties that could be returned from the function to allow a more dynamic way to define more of the mundane validation properties? Should we also look at adding functionality like lodash's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for joi-json. This package is a missing piece of functionality to joi, in my humble opinion. The ability to define validation in data structures instead of raw code is a key draw to joi/joi-json.
Unfortunately, there are a few things that joi can do that joi-json cannot. This PR adds support for dynamic defaults by registering callback functions with the parser that can be invoked if a string is supplied as a default that contains enclosing parentheses.
For example, if we had a list of Express routes with separate validation profiles:
What if we wanted "50" to be a global default defined in a central configuration using the config package, we could define a callback that would pull it from a global configuration:
Pretty powerful, yeah?