Strip internal API fields from SearchResult response#119
Open
yorkeccak wants to merge 1 commit into
Open
Conversation
Remove SearchResult.metadata passthrough field that exposed arbitrary internal API data (cost IDs, routing keys, secrets) to SDK callers. Add test to verify internal fields are not leaked. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SearchResult.metadata: Optional[Dict[str, Any]]fromresponse.py- this field was a passthrough that exposed arbitrary internal API data (cost IDs, routing keys, secrets) directly to SDK callersmetadatafield rather than passing it through to callerstests/test_sdk_api_parity.py::test_py_sdk_data_leakto verify the field is no longer exposedTask Context
c8a59c4eintern/c8a59c4eOriginal Request
Repo: valyu-py
File: SDK response handling
Category: injection
Severity: high
Test code (must pass after fix):
tests/test_sdk_api_parity.py::test_py_sdk_data_leak
Apply the minimal fix to resolve this vulnerability. Run the test to confirm it passes.
Attachments
None