Update max_tokens to max_completion_tokens in OpenAiService - #5
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Operator app’s OpenAiService to use the newer OpenAI Chat Completions request parameter name max_completion_tokens in place of max_tokens, aligning the service configuration with updated API specs.
Changes:
- Switch Chat Completions request option from
max_tokenstomax_completion_tokensinOpenAiService. - Update the corresponding unit test expectation to match the new parameter name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/operator/src/services/openai.ts | Updates the Chat Completions request payload to use max_completion_tokens. |
| apps/operator/src/services/openai.test.ts | Adjusts test expectations to assert max_completion_tokens is sent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the OpenAiService to use
max_completion_tokensinstead ofmax_tokens. This change aligns the code with the latest API specifications. The update affects the service's configuration for chat completions.How to test
Run
pnpm testto ensure all tests pass.Verify that the chat completion functionality works as expected with the updated token parameter.
Security review
Secrets / env vars: not changed.
Auth / session: not changed.
Network / API calls: not changed.
Data handling / PII: not changed.
Dependencies: not changed.
No security-impacting changes identified. The update solely modifies the parameter name without altering functionality.