ci: publish :latest alias on main builds - #22
Merged
Conversation
The docker job currently only tags the image with the short commit SHA, so downstream pins (e.g. in open-aea's libp2p integration test fixture) have to bump the SHA on every ACN release. Add a ``:latest`` tag on main builds so consumers that just want "the current image" have a stable reference. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
OjusWiZard
approved these changes
Apr 15, 2026
DavidMinarsch
approved these changes
Apr 15, 2026
DhairyaPatel7
added a commit
to valory-xyz/open-aea
that referenced
this pull request
Apr 15, 2026
…CN image Background: test_dht.py was skipped on the libp2p v0.8 -> v0.33 bump because the deployed valory/open-acn-node:latest image was still a libp2p v0.8 build and wire-incompatible with the new connection code. The ACN has since been rebuilt at valory/open-acn (Go 1.24 + libp2p v0.33.2) — the first image compatible with this branch. Point the docker fixture, CI pull step and comments at the new image via the ``:latest`` alias (published by valory-xyz/open-acn#22) and strip the blanket skip marker from the Local variants. While verifying locally against the new image, found a second wire compatibility issue: libp2p v0.33 refuses to dial a ``/dns4/0.0.0.0/...`` multiaddr ("no good addresses"), so every entry- peer URI that the fixture built from the bind-all wildcard would fail to bootstrap. v0.8 tolerated 0.0.0.0 as a dial target. Switch META_ADDRESS to 127.0.0.1 in both acn_image.py and conftest.py — the value is used both for binds (loopback is fine) and for peer entry points (loopback is now required). Public variants still rely on the production fetchai/valory ACN nodes, which have not yet been redeployed; keep them skipped with a dedicated marker until upstream redeploys. TestDHTRobustness already has its own CI-skip marker; no other gating needed for it. Verified the new ACN image locally: * boots and emits the expected peer ID * two-container bootstrap succeeds with /dns4/127.0.0.1/ multiaddrs Full pytest run cannot complete on macOS because Docker Desktop does not expose network="host" ports to the host loopback; Linux CI will exercise the end-to-end path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
DhairyaPatel7
added a commit
to valory-xyz/open-aea
that referenced
this pull request
Apr 15, 2026
Reflects the changes in the previous commit: ACN image rebuilt at valory/open-acn (new repo) with a ``:latest`` alias from valory-xyz/open-acn#22, 0.0.0.0 → 127.0.0.1 dial-format fix, narrower skip marker that now only guards the Public variants. Also bump the test_libp2p conftest copyright year to pass check-copyright on the edits from the previous commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docker job currently only tags the pushed image with the short commit SHA:
```yaml
tags: valory/${{ github.event.repository.name }}:${{ steps.vars.outputs.sha_short }}
```
So Docker Hub only ever shows SHA-style tags (`d6bf387`, `d2d4581`, `d27c2ac`, …) and there is no `:latest`. That forces every downstream consumer — notably the libp2p integration tests in `valory-xyz/open-aea` — to pin a specific SHA and bump it on every ACN release.
Add a `:latest` alias pointing at whatever main is currently on, so "the current image" has a stable reference while the SHA tag is still available for reproducible pins.
Changes
Test plan