chore(ci): [OPE-1905] parameterize squid image build by squid folder - #124
Open
atepem wants to merge 1 commit into
Open
chore(ci): [OPE-1905] parameterize squid image build by squid folder#124atepem wants to merge 1 commit into
atepem wants to merge 1 commit into
Conversation
This was referenced Sep 4, 2026
atepem
changed the title
build-squid-image.yaml hardcoded predict-polymarket in two places: the image name and the Docker build context. Take a `squid` input instead, matching deploy-subgraph.yaml's `subgraph` input (required string, no default) so the two workflows read the same way. The name is interpolated into a filesystem path and an image name, so it is validated against ^[a-z0-9][a-z0-9-]*$ before use, and a post-checkout step confirms squids/<name>/Dockerfile exists (listing the available squids on failure) rather than letting buildx fail on a missing context. Main-branch gate and the linux/amd64 pin are untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
atepem
force-pushed
the
chore/parameterize-squid-image-build
branch
from
September 7, 2026 07:58
317b6cf to
4e8d482
Compare
atepem
changed the base branch from
main
to
chore/bump-vulnerable-resolutions
September 7, 2026 07:58
Tanya-atatakai
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
build-squid-image.yamlwas hardcoded topredict-polymarketin two places — the image name and the Docker build context — so it could only ever build the one squid. It now takes asquidinput naming the folder undersquids/.Needed by #125 , which adds a second squid.
Changes
squidinput, alongside the existingversion.<registry>/$INPUT_SQUID-squid(was hardcoded)../squids/${{ inputs.squid }}(was hardcoded).run-namenow shows which squid is building.Two guards, because the value is interpolated into a filesystem path:
^[a-z0-9][a-z0-9-]*$before use — no slashes, dots or uppercase.squids/<name>/Dockerfileexists, and lists the available squids on failure rather than letting buildx fail on a missing context.Main-branch gate and the
linux/amd64pin are untouched.Note for review
The input is
required: truewith no default, matchingdeploy-subgraph.yaml'ssubgraphinput so the two workflows read the same way. The tradeoff: existing polymarket builds now need the name typed rather than defaulting. Happy to default it topredict-polymarketif you'd rather — one line.Testing
YAML validated and the logic reviewed by hand. Not dispatched:
workflow_dispatchonly runs frommain, and a run pushes a real image, so the first true test is the first use after merge.🤖 Generated with Claude Code