-
Notifications
You must be signed in to change notification settings - Fork 1
Get the first draft up there #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
teamcons
wants to merge
30
commits into
vala-community:main
Choose a base branch
from
teamcons:initial_release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
caedc4b
Get the first draft up there
teamcons d05b665
forgor meson dependency
teamcons 77012e6
Add CI
teamcons 64b6e96
Make the json optional
teamcons c7833f2
Comprehensive readme
teamcons ca35a8d
I think this has to be an unowned, right?
teamcons 1ec86db
Add a demo for upcoming tostring
teamcons fbd5cbf
add the dynamical internal unique storage thingy
teamcons 61059c2
create string counterpart
teamcons 05bf41a
add in the demo to be able to test without installing
teamcons b4979a8
more info
teamcons 591cccc
Allow building for windows
teamcons 5ded2da
Update README.md
teamcons 2be275f
Update README.md
teamcons 678681c
add is_empty()
teamcons 5ea9698
add in method to add later
teamcons ea06dd4
add contains() and do better is_empty()
teamcons f92ea99
Explicit getter setter default
teamcons 0b9f87f
code style, debug
teamcons e0323e9
Add read-only
teamcons 5d17210
Keep a Glib.File ref and add delete, but theres simplification doable…
teamcons a429e4c
make datadir check static, make linter happy, follow camelcase conven…
teamcons 80ffdee
Explicit GLib to silence warnings, and disable valadoc making stuff fail
teamcons 871cf8e
Some renaming
teamcons b468bd0
Add an init() and a couple static values
teamcons 29ccbea
Niceify README
teamcons 047390b
Add demo executable
teamcons 5dee412
meson for demo
teamcons b56f57d
fix minimistake
teamcons 556026e
fix minimistake - dependency should be a string
teamcons File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - reopened | ||
| - synchronize | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| version: [stable, unstable, development-target] | ||
| container: | ||
| image: ghcr.io/elementary/docker:${{ matrix.version }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - name: Install Dependencies | ||
| run: | | ||
| apt update | ||
| apt install -y meson valac libjson-glib-dev | ||
| - name: Build | ||
| run: | | ||
| meson setup build --prefix=/usr | ||
| ninja -C build | ||
| ninja -C build install | ||
|
|
||
| lint: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| container: | ||
| image: valalang/lint | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - name: Lint | ||
| run: io.elementary.vala-lint -d . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Testing and demo purposes | ||
| // valac --pkg libfridge demo.vala | ||
|
|
||
| public static int main (string[] args) { | ||
|
|
||
| var sto = new Fridge.StringStorage (); | ||
| print ("\n" + "Location: " + sto.storage_path + "\n"); | ||
|
|
||
| switch (args[1]) { | ||
| case "load": print (sto.content);break; | ||
| case "save": sto.content = args[2];break; | ||
| default: ;break; | ||
| } | ||
|
|
||
| return 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
|
|
||
| executable( | ||
| 'libfridge-demo', | ||
| 'demo.vala', | ||
|
|
||
| dependencies: [ | ||
| dependency ('libfridge-0.1') | ||
| ], | ||
|
|
||
| install: true, | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing purposes, Taking advantage of meson’s test features would be convenient. These could run in CI actions too! For example: https://github.com/vala-lang/vala-lint/tree/master/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. I was thinking of doing a local fork of the Slate app (text editor that saves in data unsaved files), so there is a everyday testing we can do