Consolidate output directories and remove legacy documentation#93
Merged
Conversation
…nreferenced docs Cleanup of dead files identified by cross-referencing every candidate against code, config.py, docker-compose, Makefile, CI, and tests: - .gitmodules: empty (1 byte), no submodules defined - blhackbox/clients/: empty placeholder package; nothing imports blhackbox.clients. pyproject auto-discovers packages (include = ["blhackbox*"]), so no packaging change is needed - docs/container-integration-review.md, docs/external-repo-assessment.md, docs/pentagi-comparison.md, docs/repo-audit.md: point-in-time analysis docs linked from nothing (README/.env.example-linked docs were kept) No surviving file references any removed path. Full test suite passes (201 passed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXPrrB6JQMBGHc19sXhcHw
… split) config.py was the only component never migrated to the v2.1 output/ layout: results_dir/reports_dir still defaulted to the top-level results/ and reports/ dirs, while skills, templates, docker mounts + entrypoint symlinks, setup.sh, README, and DOCKER.md all use output/. Effect: on the host / Claude Code Web path the core MCP tools (aggregate_results, generate_report) wrote session JSON and reports to results/ + reports/, while the agent's hand-authored docs (per the skills) went to output/ -- splitting a single engagement across two trees and leaving the documented output/ folders looking empty. In Docker the core server isn't wired in, so results/ + reports/ were never written at all. Reconciliation: - config.py: results_dir -> output/sessions, reports_dir -> output/reports (still overridable via RESULTS_DIR / REPORTS_DIR env vars) - remove now-dead top-level results/ and reports/ (.gitkeep) - drop the stale "legacy" results/reports rules from .gitignore - .dockerignore: results/ -> output/ to keep runtime scan data out of the build context (preserves the original protective intent) - sync now-inaccurate docstrings in reporting/paths.py and the generate_report tool description to output/reports/... MCP tool schemas and the AggregatedPayload contract are unchanged. Full test suite passes (201 passed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXPrrB6JQMBGHc19sXhcHw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the fragmented output directory structure into a single
output/hierarchy and removes outdated comparative analysis documentation that is no longer maintained.Key Changes
Directory Structure Consolidation:
results/andreports/directories underoutput/sessions/andoutput/reports/respectivelyblhackbox/config.pyto pointresults_dirandreports_dirto the new consolidated pathsblhackbox/reporting/paths.pydocstring to reflect new structure.gitignoreto ignoreoutput/instead of separateresults/andreports/entries.dockerignoreto ignore consolidatedoutput/directory.gitkeepplaceholder files from oldresults/andreports/directoriesDocumentation Cleanup:
docs/pentagi-comparison.md— detailed architectural comparison with PentAGI that is no longer actively maintaineddocs/external-repo-assessment.md— assessment of HexStrike AI, BOAZ-MCP, and BOAZ_beta that has been superseded by integrated implementationsdocs/repo-audit.md— point-in-time audit findings that are no longer currentdocs/container-integration-review.md— container topology documentation that is now covered in the main READMEMinor Updates:
blhackbox/mcp/server.pyto reference new report path structure.gitmodulesfileImplementation Details
The consolidation maintains backward compatibility at the application level — all path resolution logic continues to work as before, but now points to a unified
output/directory tree. This simplifies the repository structure and makes it clearer to operators where all generated artifacts are stored.The removed documentation files represent earlier analysis phases that have been incorporated into the codebase through actual feature implementations (HexStrike and BOAZ integration, tool discovery enhancements). Keeping them would create maintenance burden without providing current value.
https://claude.ai/code/session_01GXPrrB6JQMBGHc19sXhcHw