Teampage#8
Open
kwokwilliam wants to merge 6 commits into
Open
Conversation
kwokwilliam
commented
Apr 15, 2019
| const TeamMember = props => { | ||
|
|
||
| let select = false; | ||
| for (let i = 0; i < props.person.teams.length; i++) { |
Member
Author
There was a problem hiding this comment.
I think you should use .forEach here instead.
I don't know if I mentioned this before, but I actually got asked on an interview once when starting to use a for int i = 0 i < etc loop if I knew how to use forEach loops and I had to convince my interviewer that I knew how to use it effectively but was just choosing to use the other method during the interview.
kwokwilliam
commented
Apr 15, 2019
| <h1 className="header">Meet the Team</h1> | ||
| <body> | ||
| <div className="teams"> | ||
| <seciton className="col-xs"> |
Member
Author
There was a problem hiding this comment.
seciton
also we can probably use an array mapping here and abstract this to another class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a pull request to comment