This repository was archived by the owner on Aug 24, 2026. It is now read-only.
Repository navigation
Switch storage to react-native-mmkv - #4
Merged
Merged
Conversation
Owner
Author
|
i noticed the android build was failing because react-native-mmkv now requires react-native-nitro-modules as a peer dependency. i installed it and now the build should pass correctly. also i previously removed the migration logic as we discussed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i swapped the old file-system storage for mmkv to make it faster. i removed the migration logic because there are no users yet, so everyone will just start fresh with mmkv. i also updated the app store to use these new functions and made sure the types were all correct. everything passes lint and tsc.