Add a serde::bytes module that encodes a Uuid as a byte string - #902
Open
ChrisJr404 wants to merge 1 commit into
Open
Add a serde::bytes module that encodes a Uuid as a byte string#902ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
The existing compact module serializes a Uuid as a [u8; 16] array, which formats like CBOR and MessagePack encode as a sequence of 16 individually tagged integers rather than a single byte string. Add a sibling serde::bytes module that uses serialize_bytes/deserialize_bytes so those formats can encode a Uuid in its natural 16 byte form. Closes uuid-rs#893
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks up #893. The compact module serializes a Uuid as a [u8; 16] array, so formats that distinguish byte strings from sequences (CBOR, MessagePack) end up encoding it as 16 individually tagged integers instead of one byte string. In the CBOR example from the issue that is 32 bytes where serialize_bytes would take 17.
This adds a serde::bytes sibling module that mirrors the compact one but goes through serialize_bytes/deserialize_bytes, reusing the existing UuidBytesVisitor for the deserialize side. It is purely additive and leaves compact untouched, so nothing changes for existing users. As KodrAus noted on the issue, having a dedicated bytes module also makes it clearer that compact is the array encoding rather than a byte-string one.