Skip to content

Potential crash consistency bug in unlink #22

Description

@paulwedeck

Hello,
I discovered a similar bug to #20 but in the unlink operation.
If unlink fails after the inode has been written to the truncate list, the truncate list recovery code will "truncate" the file to its former size.
During this operation, it updates the file timestamp.

I think this is invalid because this is neither the original nor the intended final state.
My fix works by only truncating the file if the new size is different from the old size.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions