feat: add createCheckRun for Check Runs API#107
Conversation
Add createCheckRun() method to post a completed check run with a given conclusion (neutral, success, failure, etc.) using the GitHub Check Runs API, which supports richer conclusions than the legacy Commit Status API.
Greptile SummaryThis PR adds three new methods —
Confidence Score: 5/5Safe to merge — all three new methods handle the GitHub Checks API constraints correctly and the integration tests cover the main failure paths. All the substantive issues raised in earlier review rounds have been addressed in this revision. The only remaining findings are docblock inaccuracies that do not affect runtime behavior. The createCheckRun docblock in src/VCS/Adapter.php still describes a narrower interface than what is implemented, which could mislead future callers. Important Files Changed
Reviews (12): Last reviewed commit: "fix: guard against status=completed with..." | Re-trigger Greptile |
| 'Deployment skipped because the commit message contains a skip pattern.' | ||
| ); | ||
|
|
||
| $this->assertTrue(true); |
There was a problem hiding this comment.
Lets avoid doing that - lets something we can assert.
If there is nothing, lets also add getCheckRun
| 'status' => 'completed', | ||
| 'conclusion' => $conclusion, | ||
| 'completed_at' => gmdate('Y-m-d\TH:i:s\Z'), | ||
| 'output' => [ |
There was a problem hiding this comment.
also has text, annotations, images..
…quire both title and summary for output block
…teCheckRun; add actions param
Add conclusion and completedAt params to createCheckRun to support one-shot completed runs; expand test assertions to cover all response fields; add failure tests (invalid repo, invalid ID) and multi-run tests (two runs on same commit, same name on different commits).
…Run and updateCheckRun
Add createCheckRun() method to post a completed check run with a given conclusion (neutral, success, failure, etc.) using the GitHub Check Runs API, which supports richer conclusions than the legacy Commit Status API.