Phase 1: correctness fixes - #160
Merged
Merged
Conversation
- Use char-safe truncation in Event::description() for NoteAdded to
avoid panicking on multi-byte UTF-8 (e.g. Japanese notes).
- Reject non-string / non-{min,max} values for the 'expected' field
in input definitions instead of serialising Rust debug output as
the expected value.
- Rename ExecutionError::DuplicateStepHeading to DuplicateStepId so
the variant name matches the actual uniqueness check on step IDs.
- Handle the Active and Finished states explicitly when applying a
second ExecutionStarted event, returning AlreadyFinished instead
of the misleading AlreadyStarted.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid panicking on multi-byte UTF-8 (e.g. Japanese notes).
in input definitions instead of serialising Rust debug output as
the expected value.
the variant name matches the actual uniqueness check on step IDs.
second ExecutionStarted event, returning AlreadyFinished instead
of the misleading AlreadyStarted.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
This is part 1 of 5 in a stack made with GitButler: