fix: self-hosted Renovate bot からの PR もフィルタ対象にする - #6
Merged
Conversation
ut-isslのself-hosted Renovate(renovate-ut-issl-self-hosted[bot])からの PRも一律Closed対象にする必要があった。author.loginを個別列挙から "renovate"プレフィックス一致に変更し、hosted/self-hosted両方および 将来のself-hostedインスタンスをまとめて対象化する。
github-actions
Bot
added
sys::SE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Renovate の hosted bot (
renovate[bot]) に加え、ut-issl では self-hosted の Renovate（renovate-ut-issl-self-hosted[bot]）も稼働しており、こちらからの PR も Tracking の対象外（一律 Closed）にする必要がある。現状のフィルタは
renovate/renovate[bot]の2つしか対象にしておらず、self-hosted からの PR が漏れていた。確認した事実
GraphQL 上の
author.login（REST/UI 表記とは異なり[bot]が付かない）:author.login__typenamerenovate[bot]renovaterenovate-ut-issl-self-hosted[bot]renovate-ut-issl-self-hostedいずれも
renovateプレフィックスを持つ。修正内容
author フィルタを個別列挙から
renovateプレフィックス一致 に変更:これで hosted / self-hosted の両方、および将来の self-hosted インスタンスもまとめて対象になる。組織内に
renovateで始まる人間アカウントは存在しないため、プレフィックス一致で誤検知の懸念はない。テスト
renovate/renovate[bot]/renovate-ut-issl-self-hosted/renovate-ut-issl-self-hosted[bot]→ MATCH、shimomura/dependabot→ skip を確認。actionlint/ YAML パースも通過。影響範囲 / 注意
mainから作成しており、Tracking を一律 Closed 化する fix: Renovate PRのTrackingを一律Closedにする #5 とは別の行（author フィルタ）を変更するため独立してマージ可能。マージ順序は問わない。