Fix signin/signout process for reliability - #79
Merged
Conversation
- upgrade PNPM support to latest version (11.5.2) - fixes build warning [WARN] The "pnpm" field in package.json is no longer read by pnpm. The following keys were ignored: "pnpm.onlyBuiltDependencies". See https://pnpm.io/settings for the new home of each setting. - add package.json engine settings to ensure NODE and PNPM versions are consistent between local dev and docker. - add .nvmrc in case developer is using NVM. - add .node-version file. - lock down pnpm version in docker.
…after Sign Out. - fix infinite redirect between setup/signin when AUTH_ENABLED=true. add missing `await connection()`. - use browser navigation instead of push/refresh as refresh will use cached useState.
…after Sign Out. - fix infinite redirect between setup/signin when AUTH_ENABLED=true. add missing `await connection()`. - use browser navigation instead of push/refresh as refresh will use cached useState.
…after Sign Out. - fix infinite redirect between setup/signin when AUTH_ENABLED=true. add missing `await connection()`. - use browser navigation instead of push/refresh as refresh will use cached useState.
Collaborator
|
Thanks for the fix. I checked the One thing I think we should adjust before merging: Minor polish: for sign-out, I’d use |
- resolve the app base URL at runtime via getAppBaseUrl() (BETTER_AUTH_URL > Vercel URL > localhost) and pass it to better-auth as origin; drop build-time-only NEXT_PUBLIC_BASE_URL (all consumers are server-side) — the browser renderer now targets the loopback origin - apply the sign-in navigation fix to sign-up; use location.replace() on sign-out so Back can't reach an authenticated page - type the sign-up submit handler as React.SubmitEvent (FormEvent is deprecated) BREAKING CHANGE: NEXT_PUBLIC_BASE_URL is no longer read. Set BETTER_AUTH_URL or rely on Vercel auto-detection.
React.FormEvent is deprecated in @types/react. Use React.SubmitEvent for form onSubmit handlers and React.SyntheticEvent where a handler is shared between a form submit and a button click.
rbouteiller
force-pushed
the
fix-signin-signout
branch
from
June 28, 2026 17:30
e8e8e35 to
0745aef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
await connection().baseURLValidated by running under Docker container.
Set AUTH_ENABLED=true
/setup -> /sign-in
/sign-in -> /
click "sign out" -> /sign-in with "Sign In" text.