Improved name location lookups in rename framework#50
Merged
PaulKlint merged 1 commit intoJun 16, 2026
Conversation
…ine2id` field of TModels (originally intended to make use-defs more precise)
sungshik
changed the title
sungshik
changed the title
toinehartman
approved these changes
Jun 16, 2026
toinehartman
left a comment
toinehartman
left a comment
Member
There was a problem hiding this comment.
Looks good! I like how we prefer the 'new' TModel-based lookup, but keep tree-based as a fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves name location lookups in the rename framework to read the new
define2idfield of TModels. Anecdotally (based on a few profiled runs; not thorough benchmarking), the Rascal renamer gets a few percent faster after this PR.Integration test succeeds: https://github.com/usethesource/rascal-core-big-tests/actions/runs/27611396733/job/81636393389