ca certs fixes and tests - #5429
Merged
Merged
Conversation
lohit-bruno
requested review from
bijin-bruno,
helloanoop,
maintainer-bruno and
naman-bruno
as code owners
August 26, 2025 12:51
lohit-bruno
force-pushed
the
ca_certs_fixes
branch
from
August 26, 2025 16:15
1445608 to
a205b67
Compare
helloanoop
requested changes
Aug 27, 2025
helloanoop
left a comment
helloanoop
left a comment
Contributor
There was a problem hiding this comment.
These are critical changes. Lets get a e2e test in that validates the functionality of using custom certs that have been added to the keychain.
lohit-bruno
force-pushed
the
ca_certs_fixes
branch
from
August 29, 2025 15:09
3b384e2 to
35656cf
Compare
lohit-bruno
force-pushed
the
ca_certs_fixes
branch
4 times, most recently
from
September 3, 2025 21:58
0c1c9e7 to
ca2f37c
Compare
lohit-bruno
changed the title
lohit-bruno
force-pushed
the
ca_certs_fixes
branch
9 times, most recently
from
September 4, 2025 10:15
541e974 to
850908a
Compare
lohit-bruno
force-pushed
the
ca_certs_fixes
branch
17 times, most recently
from
September 7, 2025 13:07
1500453 to
3db165b
Compare
Contributor
|
@lohit-bruno As discussed, please make the |
lohit-bruno
force-pushed
the
ca_certs_fixes
branch
from
September 7, 2025 16:55
6f6e06a to
1a9a94d
Compare
lohit-bruno
force-pushed
the
ca_certs_fixes
branch
from
September 7, 2025 17:03
1a9a94d to
eb7d542
Compare
helloanoop
approved these changes
Sep 7, 2025
Contributor
|
Nice work @lohit-bruno 👏 👏 ❤️ |
lohit-bruno
added a commit
to lohit-bruno/bruno
that referenced
this pull request
Sep 7, 2025
Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
naman-bruno
pushed a commit
to naman-bruno/bruno
that referenced
this pull request
Sep 8, 2025
Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
pooja-bruno
pushed a commit
to pooja-bruno/bruno
that referenced
this pull request
Sep 11, 2025
Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
maxenceleblanc
pushed a commit
to maxenceleblanc/curly_cats2
that referenced
this pull request
Jul 20, 2026
Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.