feat:interpolate variables in code snippet modal - #62
Open
adwait-bruno wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #57.
REF:BRU-4007
Adds an Interpolate Variables checkbox to the code snippet modal, in both the docs and the playground.
Docs
The modal opens matching the global Show vars toggle, so expanding a snippet never changes what the code says. From that point the checkbox takes over for that modal only,leaving the page toggle untouched. Reopening the modal syncs it to the toggle again.
The inline snippet box on docs pages is unchanged and still follows Show vars.
Playground
The modal does not follow Show vars at all. The toggle belongs to the docs reading experience and can be hidden behind the playground dock, so the checkbox is the only control here.
Secrets
Secrets can also be interpolated only in the playground snippets (parity with app).
Images:
