-
Notifications
You must be signed in to change notification settings - Fork 7
fix: Allow matching the menu's width to the trigger #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arpit-bruno
merged 3 commits into
usebruno:main
from
vasharma05-bruno:fix-menu-dropdown-width
Aug 12, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
packages/bruno-api-docs/e2e/tests/environments/env-switcher-menu-width.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { test, expect } from '../../playwright'; | ||
|
|
||
| /** | ||
| * The environment switcher passes `matchTriggerWidth` to its MenuDropdown, so | ||
| * the menu is floored at the trigger's width and never renders narrower than the | ||
| * button that opened it. The env names here are short, so the menu's natural | ||
| * content sits at the dropdown's 10rem floor; we widen the trigger past that | ||
| * floor to prove the popover grows to match a wider trigger. | ||
| */ | ||
|
|
||
| const DESKTOP = { width: 1280, height: 900 }; | ||
|
|
||
| test.describe('env switcher menu width', () => { | ||
| test.use({ viewport: DESKTOP }); | ||
|
|
||
| test('the menu is never narrower than the trigger that opened it', async ({ overviewPage, envSwitcher }) => { | ||
| await overviewPage.goto('/'); | ||
|
|
||
| await envSwitcher.trigger.evaluate((el) => { | ||
| (el as HTMLElement).style.minWidth = '300px'; | ||
| }); | ||
|
|
||
| await envSwitcher.open(); | ||
| await expect(envSwitcher.menu).toBeVisible(); | ||
|
|
||
| const trigger = await envSwitcher.trigger.boundingBox(); | ||
| const surface = await envSwitcher.surface.boundingBox(); | ||
| if (trigger === null || surface === null) throw new Error('env switcher has no bounding box'); | ||
|
|
||
| expect(surface.width).toBeGreaterThanOrEqual(trigger.width - 1); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.