-
Notifications
You must be signed in to change notification settings - Fork 7
fix: Fix the lagged responsiveness of tabs with response actions #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arpit-bruno
merged 6 commits into
usebruno:main
from
vasharma05-bruno:fix/response-tabs-with-actions
Aug 11, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e111f4c
Match the hover state of Menu dropdown trigger to the Bruno app
vasharma05-bruno 985afc1
Fix the responsive action buttons collapse and tabs
vasharma05-bruno c94bbed
Restore stylings
vasharma05-bruno d0a8b14
Fix the broken responsiveness
vasharma05-bruno 2e35230
Review changes
vasharma05-bruno c23fd1b
Fix failing test
vasharma05-bruno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...und/Content/Views/PlaygroundView/ResponsePane/ResponseActions/hooks/useResponseActions.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { useCallback, useRef, useState } from 'react'; | ||
|
|
||
| export default function useResponseActions() { | ||
| const [actionsExpandedWidth, setActionsExpandedWidth] = useState<number>(); | ||
| const actionsMeasureObserver = useRef<ResizeObserver | null>(null); | ||
| // Track the rendered width of a hidden expanded copy of the actions so the tab bar always has an | ||
| // up-to-date figure (it shifts with theme/font, not just at mount) without hardcoding a constant. | ||
| // The node is a measurement-only copy, so mark it inert to keep it out of focus/pointer/a11y — | ||
| // set imperatively because React 18 doesn't pass the `inert` prop through (see ExampleCard). | ||
| const measureActions = useCallback((node: HTMLDivElement | null) => { | ||
| actionsMeasureObserver.current?.disconnect(); | ||
| if (!node) return; | ||
| if (typeof ResizeObserver === 'undefined') return; | ||
| const update = () => setActionsExpandedWidth(node.offsetWidth || undefined); | ||
| update(); | ||
| actionsMeasureObserver.current = new ResizeObserver(update); | ||
| actionsMeasureObserver.current.observe(node); | ||
| }, []); | ||
|
|
||
| return { actionsExpandedWidth, measureActions }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...s/Playground/Content/Views/PlaygroundView/ResponsePane/ResponseFormatter/StyledWrapper.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import styled from '@emotion/styled'; | ||
|
|
||
| export const StyledWrapper = styled.div` | ||
| .menu-dropdown-trigger { | ||
| &:hover { | ||
| border-color: var(--oc-colors-text-subtext2); | ||
| } | ||
|
|
||
| .menu-dropdown-trigger-label svg { | ||
| color: var(--oc-brand); | ||
| } | ||
| } | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.