fix: correct CCSDS packet length calculation - #4
Merged
Conversation
Signed-off-by: 0rlych1kk4 <orlychikka@gmail.com>
Contributor
|
thanks for finding this and fixing it! |
Contributor
Author
|
Thanks, glad I spotted it. Nice to get the length calculation and regression coverage cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
CcsdsTcPacketOwned::len_written()andCcsdsTmPacketOwned::len_written()to use the length of the already-serializedpayload bytes instead of the postcard serialized size of the
Vec<u8>container.Previously,
len_written()overestimated the actual packet length becausepostcard serialization of a
Vec<u8>includes its length prefix, whilewrite_to_bytes()copies the payload bytes directly.Testing
Added regression tests verifying:
For both TC and TM packets.
Verified with:
cargo test -p types