FIX: add validation for containerID

[kaizakin]

Description

• added containerID validation following the similar approach as runc

Almost every command in urunc delete, kill, ps, start, run, and the internal re-exec phase calls the shared getUnikontainer() helper function to read the container ID from the command line and load its state.
by adding validateID inside this helper we've automatically secured all commands.

only the create command doesn't use the getUnikontainer() because the container state hasn't been initialized yet
so i explicitly added validateId there.

• Fixes we should probably validate containerID before constructing the containerDir path #714

How was this tested?

Manually tested by locally compiling urunc and simulating the path traversal attack vector

LLM usage

N/A

Checklist

• I have read the contribution guide.
• The linter passes locally (make lint).
• The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
• If LLMs were used: I have read the llm policy.

[netlify]

✅ Deploy Preview for urunc canceled.

Name	Link
🔨 Latest commit	77e47c0
🔍 Latest deploy log	https://app.netlify.com/projects/urunc/deploys/6a410e0c95d4500008c0e430

[kaizakin]

Hey @cmainas

what's your opinion on this comment #714 (comment)
saying about securejoin.SecureJoin(root, id) instead of filepath.Join

[mdryaan]

Hi @kaizakin, I think two things to fix:

1. cmd/urunc/utils.go "path/filepath" is in the wrong import group (will fail CI lint)

path/filepath is stdlib it needs to go in the same group as the other stdlib imports, not in its own group between stdlib and external. goimports is enabled in golangci-lint v2 and is checked during golangci-lint run.

2. go.mod revert the filepath-securejoin entry

github.com/cyphar/filepath-securejoin is not imported anywhere in the code , validateID only uses stdlib path/filepath. Looks like leftover from an earlier attempt. Revert the go.mod change.

The validation logic and placement look correct.

cc @cmainas

[kaizakin]

Thanks for the review @mdryaan

[cmainas]

Hello @kaizakin ,

thank you for the PR. I have added a few small comments. Overall it looks good.

[kaizakin]

Thanks for the review @cmainas
I've made all the requested changes PTAL.