Tenure fixes - #4
Open
jessicacamacho wants to merge 12 commits into
Open
Conversation
Member
|
Hi @jessicacamacho, thank you -- this looks great. I'm going to run a full simulation using this branch, to make sure that it works on my machine and that i understand what it's doing. But from looking through the code, everything looks good! |
Author
|
Hi @smmaurer! I have added a few commits to update the Jupyter notebook and added the Let me know if you have any questions. Thanks!! Jessica |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @smmaurer,
Regarding https://github.com/urbansim/consulting-planning/issues/339, this PR adds the changes to fix tenure imbalances and enables using the
tenurevariable forunitsandhouseholds.To show evolution of tenure, I created the
Implementing Housing Tenurenotebook, which runs the model for scenarios 4 and 5 and retrieves the tenure values for households and units using the newunits_tenure_trackandhouseholds_tenure_trackinjectables. The notebook plots evolution of tenure split for these scenarios, and shows that all renter households were assigned to renter units only, all owner households were assigned to owned units, and no households havenullor-1values forunit_id.Please let me know if you have any questions, or would like me to make any changes.
Thanks!
Jessica