Fixing play state conflict#135
Open
HoMinhNhat123 wants to merge 11 commits into
Open
Conversation
…ovider in frontend
merging the latest version of repo before pull request in 6/14/2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed a bug in
playNodesUpToinFlowProvider.tsxwhere calling it whileplayAllNodeswas already running would cause nodes to re-execute mid-run concurrently. This is especially harmful for slow nodes — a user repeatedly clicking a node while it is still loading would keep restarting execution, and the node would never finish. The fix adds a guard at the top ofplayNodesUpTo:Added unit tests for
FlowProviderto document and prove existing bugs in 'playNodesUpTo'. The tests cover:onConnectcorrectly initializes merge node source slots when connecting multiple nodesapplyNewOutputpropagates output to correct downstream nodesapplyNewOutputhandles merge flow nodes with multiple inputsplayAllNodesexecutes nodes in topological order level by levelplayNodesUpTocorrectly guards against running whileplayAllNodesis in progress (proving the bug whereplayNodesUpTohad no guard againstplayAllStateRef, which would cause nodes to re-execute mid-run)Issue resolved by this PR (if any)
Type of change (Check all that apply)
Parts of Curio impacted by this PR:
Testing
./scripts/test.shand it passed all tests.Screenshots (if relevant)
Checklist (Check all that apply)
tests/folder into Curio, ran all the nodes one by one, and checked that they run without errors and give the expected results