Andres feature#134
Open
AndresDoesCode wants to merge 3 commits into
Open
Conversation
I added more test cases to the sandbox
I finished writing test cases for the backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
I added more test cases covering the Backend and Sandbox
Sandbox Tests
JS code receives Python-DuckDB-stored input via the arg parameter
Floats can be inserted and accsess from duckDB without any side effects
Strings are stored and accsessed gracefully with DuckDB
Tests whether data will flow nicely from Python to JS nodes
null and undefined return types are handled gracefully
This tests the isolation of sessions. Can one session grab information from another?
Backend Tests
Type of change (Check all that apply)
Parts of Curio impacted by this PR:
Testing
./scripts/test.shand it passed all tests.Checklist (Check all that apply)
tests/folder into Curio, ran all the nodes one by one, and checked that they run without errors and give the expected results