Repository navigation
fix(packs): pack test counts truth sites listed as folded evidence as covered - #165
Merged
lucasbraum merged 1 commit intoOct 16, 2026
Conversation
… covered A ground-truth site that an anchored finding lists as evidence (TypeScript 6 `types` errors folded into changed-defaults, #136's option cascades) now scores as covered, at the site's own rule and severity. Evidence the truth does not name stays unscored. Ground truth unchanged. Re-scored typescript: breaking recall 17% -> 99% (1,379 of 1,399), 0 FP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Lucas Braum <lucasbraum@gmail.com>
lucasbraum
merged commit Oct 16, 2026
90c45cb
into
lucasbraum/promote-verified-packs
28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #160 (base is its branch; retarget to main once #160 merges).
What
predictedSites(packs/tooling/pack-test.ts) now takes the repository's expected sites. When an anchored finding lists one asdownstreamevidence, that site counts as covered, at the truth's own rule and severity. Examples: TypeScript 6types: []errors folded into onechanged-defaultsfinding per tsconfig, and #136's TS7006 option cascades. So covered sites add true positives to the breaking and overall tallies and to their own rule. They don't inflate the behavior-note tally. Evidence the truth doesn't name stays unscored, as before. No ground-truth changes.Re-score: typescript (
--write, once)The 20 remaining breaking misses are the second-round and same-change lines RESEARCH.md already lists. README table, RESEARCH.md and verification.json are updated; the change to docs/packs.md is one sentence. Packs whose records include anchored evidence may show changed numbers on the next run. The scorer only adds true positives, so no false positive count or gate verdict can change.
Checks
vitest runin core: 1,857 passed. ThepredictedSitesevidence test now also covers a named evidence site.pnpm lint(pre-existing warnings only),typecheck,docs:packs --check,public:checkpass.🤖 Generated with Claude Code