fix(scripts): repair watch entry path, drop dead coverage:verify - #29
Open
menor wants to merge 1 commit into
Open
fix(scripts): repair watch entry path, drop dead coverage:verify#29menor wants to merge 1 commit into
menor wants to merge 1 commit into
Conversation
|
Coverage after merging fix/npm-scripts into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
menor-pro
pushed a commit
that referenced
this pull request
Jul 29, 2026
- watch pointed at index.ts, which does not exist; the entry is src/index.ts - coverage:verify called scripts/check-coverage.sh, which was never committed; coverage:check already enforces the thresholds in jest.config.ts
menor-pro
force-pushed
the
fix/npm-scripts
branch
from
July 29, 2026 04:59
04a639d to
78b2bd7
Compare
|
Coverage after merging fix/npm-scripts into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two
package.jsonscripts were broken:watchrantsx watch index.ts. That file does not exist. The entry point issrc/index.ts.coverage:verifycalledscripts/check-coverage.sh. The script was never committed.Fix
watchatsrc/index.ts.coverage:verify.coverage:checkalready enforces the thresholds defined injest.config.ts(global plus per-folder overrides), so the entry was redundant even if the shell script existed.Verification
Ran
npm run watchon this branch. The server compiles and boots (telemetry, config, and startup logs appear; process stays up and watches for changes).Merge order
Merge this before #28. That PR removes the broken-scripts warning from CLAUDE.md, which only becomes true once this lands.