Skip to content

fix(scripts): repair watch entry path, drop dead coverage:verify - #29

Open
menor wants to merge 1 commit into
mainfrom
fix/npm-scripts
Open

fix(scripts): repair watch entry path, drop dead coverage:verify#29
menor wants to merge 1 commit into
mainfrom
fix/npm-scripts

Conversation

@menor

@menor menor commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What

Two package.json scripts were broken:

  • watch ran tsx watch index.ts. That file does not exist. The entry point is src/index.ts.
  • coverage:verify called scripts/check-coverage.sh. The script was never committed.

Fix

  • Point watch at src/index.ts.
  • Delete coverage:verify. coverage:check already enforces the thresholds defined in jest.config.ts (global plus per-folder overrides), so the entry was redundant even if the shell script existed.

Verification

Ran npm run watch on this branch. The server compiles and boots (telemetry, config, and startup logs appear; process stays up and watches for changes).

Merge order

Merge this before #28. That PR removes the broken-scripts warning from CLAUDE.md, which only becomes true once this lands.

@github-actions

Copy link
Copy Markdown

Coverage after merging fix/npm-scripts into main will be

92.64%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   mcpUpsun.ts96%75%100%97.44%171–172
src/command
   activity.ts100%100%100%100%
   backup.ts100%100%100%100%
   certificate.ts100%100%100%100%
   domain.ts100%100%100%100%
   environment.ts98.70%94.44%100%100%339
   organization.ts100%100%100%100%
   project.ts91.49%66.67%100%100%139, 173, 71, 78
   route.ts100%100%100%100%
   ssh.ts100%100%100%100%
src/core
   authentication.ts85.71%77.08%95%88.89%113–114, 133, 218–219, 221, 296–298, 321, 332–333, 353–354, 354, 354, 354, 354–355
   config.ts91.47%91.04%100%91.04%121, 133, 140, 140, 140, 140, 142, 145, 149, 156, 156, 160, 162, 316, 353, 36, 51, 62
   gateway.ts80.52%100%66.67%81.67%261–264, 288, 291–292, 294–295, 299, 303
   helper.ts89.84%81.48%100%91.43%208–209, 241–242, 337, 341–342, 349, 353, 422–424, 461–462, 512–513, 517, 544–545
   lean.ts90.70%88.89%100%90.91%85, 88, 91, 95
   logger.ts98.61%96.15%100%100%83
   requestContext.ts100%100%100%100%
   telemetry.ts92.09%88.57%100%92.55%163, 200–201, 250–251, 299–300, 350–351, 372–373
   types.ts100%100%100%100%
src/core/transport
   http.ts83.56%80%81.25%85.26%102, 102, 102–103, 158–159, 174–175, 183–184, 189–190, 204–205, 208, 51–52, 55, 92, 95, 97
   sse.ts82.29%63.64%85.71%88.06%100, 102–103, 114, 135, 54–55, 58, 81–82, 85, 99, 99, 99, 99, 99
src/task
   config.ts100%100%100%100%

- watch pointed at index.ts, which does not exist; the entry is src/index.ts
- coverage:verify called scripts/check-coverage.sh, which was never committed;
  coverage:check already enforces the thresholds in jest.config.ts
@github-actions

Copy link
Copy Markdown

Coverage after merging fix/npm-scripts into main will be

92.64%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   mcpUpsun.ts96%75%100%97.44%171–172
src/command
   activity.ts100%100%100%100%
   backup.ts100%100%100%100%
   certificate.ts100%100%100%100%
   domain.ts100%100%100%100%
   environment.ts98.70%94.44%100%100%339
   organization.ts100%100%100%100%
   project.ts91.49%66.67%100%100%139, 173, 71, 78
   route.ts100%100%100%100%
   ssh.ts100%100%100%100%
src/core
   authentication.ts85.71%77.08%95%88.89%113–114, 133, 218–219, 221, 296–298, 321, 332–333, 353–354, 354, 354, 354, 354–355
   config.ts91.47%91.04%100%91.04%121, 133, 140, 140, 140, 140, 142, 145, 149, 156, 156, 160, 162, 316, 353, 36, 51, 62
   gateway.ts80.52%100%66.67%81.67%261–264, 288, 291–292, 294–295, 299, 303
   helper.ts89.84%81.48%100%91.43%208–209, 241–242, 337, 341–342, 349, 353, 422–424, 461–462, 512–513, 517, 544–545
   lean.ts90.70%88.89%100%90.91%85, 88, 91, 95
   logger.ts98.61%96.15%100%100%83
   requestContext.ts100%100%100%100%
   telemetry.ts92.09%88.57%100%92.55%163, 200–201, 250–251, 299–300, 350–351, 372–373
   types.ts100%100%100%100%
src/core/transport
   http.ts83.56%80%81.25%85.26%102, 102, 102–103, 158–159, 174–175, 183–184, 189–190, 204–205, 208, 51–52, 55, 92, 95, 97
   sse.ts82.29%63.64%85.71%88.06%100, 102–103, 114, 135, 54–55, 58, 81–82, 85, 99, 99, 99, 99, 99
src/task
   config.ts100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant