fix: avoid undefined metadata when retrieval finds no context#109
Open
alejosworkstuff wants to merge 1 commit into
Open
fix: avoid undefined metadata when retrieval finds no context#109alejosworkstuff wants to merge 1 commit into
alejosworkstuff wants to merge 1 commit into
Conversation
Empty retrieval used to leak undefined metadata entries (topK=5).
Return [] when no context and coerce missing metadata to {}.
Closes upstash#49
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat()no longer returns a fixed-size array ofundefinedmetadata entries (defaulttopKis 5).Database.retrievenow returns[]when every result has undefined data, and coerces missing metadata to{}.ContextServicemirrors that empty-metadata behavior.Test plan
bun test src/database.retrieve.test.ts(mock Index; 3 new cases)