fix: don't retry when retry is disabled#273
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272
Summary
When
HttpClientwas configured withretry: false, a failing request still calledfetchtwice instead of once. Theretry: falsebranch normalized toattempts: 1, but since #207 the request loop treatsattemptsas the number of retries after the initial attempt (index <= attempts), so1meant "one extra retry" rather than "one total attempt".Changes
Normalize
retry: falsetoattempts: 0insrc/client/http.ts, so a disabled-retry client performs exactly one fetch attempt. Object-form semantics ({ retries: N }→ N retries after the initial attempt) are unchanged.Add tests covering both cases:
retry: falsecallsfetchexactly once, and{ retries: 1 }calls it twice.Testing
bun test src/client/http.test.ts— 3 pass, 0 fail (new tests plus the existing backoff-timing test).